Added support to delta in core matched by mem in alts#16
Open
Pr1ms wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
As I've mentionned to you about a week ago autoCR flags a IMPROPER_DELTA when there is a Delta in Core that is matched by a Mem in every Alt.
Examples:
https://authorblues.github.io/retroachievements/AutoCR/#!/game/24342/achievement/606386
https://authorblues.github.io/retroachievements/AutoCR/#!/game/9/achievement/4341
This PR aims at fixing this issue.
It may need a moment for a proper review since I've not drunk my morning coffee yet (I've tested that the above-mentionned examples are now working but there could now be false negatives if I made some kind of mistake).
Cheers!