Allow specifying allowed outgoing ips

[evanyeyeye]

Description

• This PR adds the option to specify allowed outgoing IPs on a per-assessment level.
• Default behavior is to allow all outgoing connections. Disable network denies all outgoing connections.
• If disable network is not checked and IPs are specified, then only those IPs are allowed.

Motivation and Context

• Adds a security option for Autolab assessments.
• Provides more flexibility compared to previous binary option of enabling network access.

How Has This Been Tested?

• Tested when IPs are specified and disable network is unchecked.
• Tested when IPs are specified and disable network is checked.
• Tested when no IPs are specified and disable network is unchecked (currently bugged).

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

[coderabbitai]

Warning

Rate Limit Exceeded

@evanyeyeye has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between c80e7b4 and ee3b340.

Walkthrough

The latest changes enhance the autograding feature by enabling the specification of allowed outgoing IP addresses for autograding containers in assessments. This update includes adding a new field allowed_outgoing_ips to the assessments database table and implementing the logic to use these IPs during job creation for autograding. Users can now specify these IPs through the assessment editing interface.

Changes

File(s)	Change Summary
app/helpers/assessment_autograde_core.rb	Updated tango_add_job function to handle allowed_outgoing_ips for job creation in autograding, converting them to an array if not empty, and including them in job_properties. job_properties are now converted to JSON before submission to TangoClient.
app/views/assessments/_edit_advanced.html.erb	Added a text field to the assessment edit view for specifying allowed outgoing IPs for autograding containers.
db/migrate/20240401200408_add_allowed_outgoing_i_ps_to_assessment.rb	Added a migration to introduce the allowed_outgoing_ips column in the assessments table to store permitted outgoing IP addresses for assessments.
db/schema.rb	Updated the database schema by adding a new column allowed_outgoing_ips to allow storage of permitted outgoing IP addresses.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[KesterTan]

This doesn't work, I think Rails expects the name to be AddAllowedOutgoingIpsToAssessment with the p as lowercase.