Skip to content

CP-14901: Bump avalanchejs to 5.1.1-alpha.2, core SDKs to alpha.94, vm-modules to 4.0.1 for final ACP-236 wire format - #4014

Merged
B0Y3R-AVA merged 1 commit into
mainfrom
boyer/cp-14767
Jul 29, 2026
Merged

CP-14901: Bump avalanchejs to 5.1.1-alpha.2, core SDKs to alpha.94, vm-modules to 4.0.1 for final ACP-236 wire format#4014
B0Y3R-AVA merged 1 commit into
mainfrom
boyer/cp-14767

Conversation

@B0Y3R-AVA

@B0Y3R-AVA B0Y3R-AVA commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Ticket: CP-14901 (upstream SDK alignment: CP-14767)

Moves mobile to the final ACP-236 wire format, now that Helicon is live on Fuji — mirroring the extension's core-extension#1000:

  • @avalabs/avalanchejs 5.1.0-alpha.55.1.1-alpha.2 (direct dep + root resolution). 5.1.0-alpha.x ships the draft ACP-236 codec; against a Fuji 1.15.0 node it misreads the new length-prefixed NodeID in AddAutoRenewedValidatorTx and fails with couldn't unmarshal interface: unknown type ID (see Slack thread and core-vm-modules#462). The codec fix is fix: align acp-236 transactions encoding (avalanchejs#1000).
  • Core SDKs 3.1.0-canary.672f5c3.03.1.0-alpha.94. The canary (cut for additionalOutputs on delegator txs) is fully contained in alpha.94 (avalanche-sdks#785), which additionally includes fix: align acp-236 transaction types (avalanche-sdks#792) — i.e. core-wallets-sdk is now compiled against the final codec, closing the "wallets-sdk rebuild" follow-up from the earlier revision of this PR (parseAddAutoRenewedValidatorTx now matches the final format).
  • vm-modules 4.0.04.0.1. The only change between the tags is chore: update sdks (core-vm-modules#463), aligning the modules' own avalanchejs/SDK pins to 5.1.1-alpha.2 / alpha.94.
  • yarn.lock confirms a single @avalabs/avalanchejs@5.1.1-alpha.2, single core-wallets-sdk@3.1.0-alpha.94, and single vm-module-types@4.0.1 after the bump — no duplicate copies that could break instanceof checks in signing code.

Screenshots/Videos

N/A — dependency bump, no UI change.

Testing

Dev Testing (if applicable)

  • tsc -p . clean (fresh build, no incremental cache).
  • Full unit suite passes: 356 suites / 4361 tests.
  • Happy path: P-Chain flows (stake, claim, cross-chain C↔P import/export) unchanged — the changed avalanchejs/SDK surfaces are scoped to ACP-236.
  • ACP-236 on Fuji: with the final codec now in both avalanchejs and wallets-sdk, AddAutoRenewedValidatorTx should unmarshal and parse end to end — pending re-verification on a Fuji build of this revision.

QA Testing (if applicable)

  • Regression-test P-Chain staking and cross-chain (C↔P) flows on both mainnet and Fuji.

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have included screenshots / videos of android and ios
  • I have added testing steps
  • I have added/updated necessary unit tests
  • I have updated the documentation

@B0Y3R-AVA
B0Y3R-AVA requested a review from a team as a code owner July 28, 2026 22:39
Copilot AI review requested due to automatic review settings July 28, 2026 22:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the monorepo to use @avalabs/avalanchejs@5.1.1-alpha.2 so Core Mobile picks up the final ACP-236 wire-format encoding/decoding behavior (via both the direct dependency and the root-level Yarn resolution), aligning mobile with Fuji’s Helicon-era node behavior.

Changes:

  • Bump @avalabs/avalanchejs from 5.1.0-alpha.55.1.1-alpha.2 in packages/core-mobile.
  • Update the root Yarn resolution for @avalabs/avalanchejs to force the whole workspace dependency tree onto 5.1.1-alpha.2.
  • Refresh yarn.lock to reflect the single resolved @avalabs/avalanchejs@5.1.1-alpha.2 entry and updated checksums.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updates the root resolution to force @avalabs/avalanchejs@5.1.1-alpha.2 across the workspace dependency graph.
packages/core-mobile/package.json Bumps Core Mobile’s direct dependency on @avalabs/avalanchejs to 5.1.1-alpha.2.
yarn.lock Records the new resolved @avalabs/avalanchejs@5.1.1-alpha.2 and related lockfile checksum updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Coverage report ✅

2/2 packages passed thresholds
Thresholds are shown inline against each package baseline.

🟢 @avalabs/core-mobile

St. Category Percentage Covered / Total
🟢 Statements 27.88% (+9.88% vs 18% ▲) 12353/44297
🟢 Branches 23.54% (+11.54% vs 12% ▲) 6066/25767
🟢 Functions 22.18% (+9.18% vs 13% ▲) 2270/10234
🟢 Lines 27.96% (+9.96% vs 18% ▲) 11829/42300

🟢 @avalabs/k2-alpine

St. Category Percentage Covered / Total
🟢 Statements 8.49% (+6.49% vs 2% ▲) 304/3578
🟢 Branches 7.90% (+6.90% vs 1% ▲) 172/2177
🟢 Functions 4.99% (+3.99% vs 1% ▲) 41/821
🟢 Lines 7.82% (+5.82% vs 2% ▲) 257/3283
Artifacts and threshold sources
  • @avalabs/core-mobile: summary core-mobile/coverage/coverage-summary.json, thresholds core-mobile/coverage-thresholds.json
  • @avalabs/k2-alpine: summary k2-alpine/coverage/coverage-summary.json, thresholds k2-alpine/coverage-thresholds.json

Source run: Mobile PR

Copilot AI review requested due to automatic review settings July 29, 2026 13:54
@B0Y3R-AVA B0Y3R-AVA changed the title CP-14767: Bump avalanchejs to 5.1.1-alpha.2 for final ACP-236 wire format CP-14767: Bump avalanchejs to 5.1.1-alpha.2, core SDKs to alpha.94, vm-modules to 4.0.1 for final ACP-236 wire format Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@B0Y3R-AVA B0Y3R-AVA changed the title CP-14767: Bump avalanchejs to 5.1.1-alpha.2, core SDKs to alpha.94, vm-modules to 4.0.1 for final ACP-236 wire format CP-14901: Bump avalanchejs to 5.1.1-alpha.2, core SDKs to alpha.94, vm-modules to 4.0.1 for final ACP-236 wire format Jul 29, 2026
@B0Y3R-AVA
B0Y3R-AVA merged commit b14d29d into main Jul 29, 2026
6 checks passed
@B0Y3R-AVA
B0Y3R-AVA deleted the boyer/cp-14767 branch July 29, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants