Conversation
Related issue: #5037 After a lot of testing, it was determined that error handling for most/all API routes was already fairly robust. The most likely cause of the error reporting issue was users making their request with the wrong HTTP method, e.x. Media Object update is required to be a PUT. Users making the request via PATCH would encounter a 500 error for the incorrect route. This commit adds handling for this situation by creating a new route that catches all requests that don't match an existing route and directing them to specific error handling to provide a 404 page or JSON error, depending on request format. Follow-up work could be to audit our API endpoints and see if there are any it might make sense to add, such as a PATCH option for API updates of Media Objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #5037
After a lot of testing, it was determined that error handling for most/all API routes was already fairly robust. The most likely cause of the error reporting issue was users making their request with the wrong HTTP method, e.x. Media Object update is required to be a PUT. Users making the request via PATCH would encounter a 500 error for the incorrect route. This commit adds handling for this situation by creating a new route that catches all requests that don't match an existing route and directing them to specific error handling to provide a 404 page or JSON error, depending on request format. This is necessary because routing errors occur in middleware which cannot be rescued via standard
rescue_fromerror handling.Follow-up work could be to audit our API endpoints and see if there are any it might make sense to add, such as a PATCH option for API updates of Media Objects.