fix: hex strings misparsed after non-string meta values - #294
Merged
Conversation
When the last value in a meta: section was an integer or boolean, the lexer stayed in the $meta state at the strings keyword. The $meta-state strings token transitioned back to @default but, unlike its @default counterpart, never set sectionStrings(true) -- so a following { was not recognized as a hex string opener and its nibbles were lexed as integers, causing a ParserError. A trailing string meta value masked the bug because the closing quote already returns the lexer to @default. Also sets sectionStrings(false) on the $meta-state condition token to mirror the @default counterpart. Adds C++ and Python regression tests. Co-Authored-By: Claude <noreply@anthropic.com>
metthal
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the last value in a meta: section was an integer or boolean, the lexer stayed in the $meta state at the strings keyword. The $meta-state strings token transitioned back to @default but, unlike its @default counterpart, never set sectionStrings(true) -- so a following { was not recognized as a hex string opener and its nibbles were lexed as integers, causing a ParserError. A trailing string meta value masked the bug because the closing quote already returns the lexer to @default.
Also sets sectionStrings(false) on the $meta-state condition token to mirror the @default counterpart. Adds C++ and Python regression tests.