fix: make PIN entry feel like a PIN input - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PIN entry now behaves like a purpose-built 4-digit code field instead of a free-form text box. Setup and unlock both render masked four-slot controls, keep numeric cleanup for typing and paste, and hold submit disabled until all 4 digits are present so incomplete input no longer round trips to validation errors.
Test Plan
bun run testbun run typecheckbun run frontend:buildhttp://127.0.0.1:5173/for the setup PIN control, disabled/enabled submit behavior, and console errors