Image generation saving error - #1
Draft
avatarneil wants to merge 2 commits into
Draft
avatarneil wants to merge 2 commits into
avatarneil wants to merge 2 commits into
Conversation
Fix error handling in SaveBracketDialog and image generation. Add package-lock.json. Co-authored-by: avatarneil <avatarneil@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: avatarneil <avatarneil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes image generation errors by adding null checking for the canvas 2D context and resolves linter warnings by removing unused error variables.
The
getContext("2d")method can returnnullunder certain conditions, but the previous code used a non-null assertion (!), causing silent failures in subsequent canvas operations and leading to the "Failed to generate image" error. This PR adds explicit null checking to prevent this.