Team icon rendering issue - #5
Draft
avatarneil wants to merge 2 commits into
Draft
Conversation
Co-authored-by: avatarneil <avatarneil@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This commit introduces several improvements to image handling: - **ESPN CDN Support:** The code now correctly identifies and processes images served from the ESPN CDN, including those optimized by Next.js. - **Next.js Image Optimization Handling:** It extracts the original image URL from Next.js optimized image URLs, allowing for proper fetching and conversion to data URIs. - **Image Pre-loading:** Images are now pre-loaded after conversion to data URIs to ensure they are ready for rendering, improving performance, especially on Safari. - **CORS Proxy Usage:** The image proxy is used to fetch images, bypassing CORS restrictions. - **Next.js Image Styling Fixes:** Adjustments are made to handle Next.js Image's absolute positioning and styling to ensure images are displayed correctly when replaced with data URIs. - **Restoration of Attributes:** Original image attributes like `srcset`, `style`, `loading`, and `decoding` are now restored after processing. - **Removed Unnecessary Filter:** The `filter` option in `html-to-image` has been removed as it was not needed and potentially problematic. Co-authored-by: avatarneil <avatarneil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes team icons not rendering on share/export by ensuring images are fully loaded before capture, especially on mobile Safari.
The issue was a race condition where dynamically changed image sources (to data URIs) were not fully rendered before the capture process, which is more pronounced and slower on mobile Safari due to its stricter image loading handling.