Keep game stats width stable across tabs - #56
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iPad Safari, the game-stats dialog's inner column can shrink to the Stats tab's intrinsic width, then expand when the Momentum chart renders. The content root now explicitly fills the dialog and allows wide children to shrink within it, keeping the field, tabs, tab content, and footer aligned across tab changes.
The new iPad-landscape regression test measures the dialog and tab panel before and after switching from Stats to Momentum and verifies that their dimensions stay stable.
Validation:
bun run type-checkbun run lint(passes with 7 existing warnings)bunx oxfmt --checkon changed filesbunx next build --webpacke2e/tests/game-stats-sizing.spec.tspasses in Chromium and Firefox CI