Repository navigation
Make the Who Is Online label plain text in every language - #210
Merged
Merged
Conversation
VIEWING_RECENT_TOPICS was 'Viewing <a href="%s">Recent Topics</a>' in all 14 language packs, but the listener calls lang() without an argument and core's viewonline template already wraps the location in its own link. Who Is Online rendered a link nested inside core's link, pointing at a literal "%s". Drop the markup and placeholder, keeping each translation's wording. Closes #199 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199.
Problem
In all 14 language packs,
VIEWING_RECENT_TOPICSwas'Viewing <a href="%s">Recent Topics</a>'. Butlistener::viewonline_overwrite_location()callslang()without an argument, and core'sviewonline_body.htmlalready wraps the location in<a href="{U_FORUM_LOCATION}">. Who Is Online therefore rendered a link nested inside core's link, pointing at a literal%s.Fix
Drop the markup and placeholder from
VIEWING_RECENT_TOPICSin ar, cs, de, de_x_sie, en, es, es_x_tu, fr, nl, pt, ru, sk, sv and uk, keeping each translation's own wording.location_urlstill supplies the link.Tests
tests/language/viewonline_lang_test.php, documented intests/tests.md, loads every language pack and checks that the label has no<and no%. It failed for all 14 packs before the fix and passes for all 14 after.Checked on the local board (boot script: the listener's real viewonline handler for an
app.php/rtsession, using phpBB's language service, with the cell built as in prosilver'sviewonline_body.html):No changelog entry or version bump, per this repo's convention.
🤖 Generated with Claude Code