Every game plugin is missing its <game>_unknown.png fallback icon

[avandenberghe]

Summary

Tracking issue for a gap that is identical in all 9 game plugins: the class_id 0 "unknown" placeholder icon each installer seeds does not exist as a file anywhere.

Plugin	seeded imagename	class_images/	roster_classes/
bbguildeq	eq_unknown	missing	missing
bbguildeq2	eq2_unknown	missing	missing
bbguildffxi	ffxi_unknown	missing	dir missing (bbguildffxi#6)
bbguildffxiv	ffxiv_unknown	missing	missing (bbguildffxiv#8)
bbguildgw2	gw2_unknown	present	missing (bbguildgw2#7)
bbguildlineage2	lineage2_Unknown	missing	missing
bbguildlotro	lotro_unknown	missing	missing (race_images has one)
bbguildswtor	swtor_unknown	missing	missing
bbguildwow	wow_unknown	not seeded	n/a

Only bbguildgw2 ships one, and only in class_images/.

Why it matters now

#389 added a fallback chain ending at <prefix>_unknown.png. That last step is the one that makes a missing class icon degrade to a sensible placeholder rather than to nothing at all — and right now it can almost never fire, because the file is absent in 8 of 9 plugins. Filling these in is what turns #389 from "no broken image" into "always shows something".

It also covers the real case, not just the defensive one: class_id 0 is what a character gets when a sync can't map its class.

Note on sourcing

Unlike the GW2 elite-spec icons (bbguildgw2#8, pulled from the official render API) there is no upstream source for these — a generic "unknown" placeholder has to be authored per plugin, at that plugin's own icon size and in its style. bbguildlotro/images/race_images/lotro_unknown.png (a "?" glyph on the set's plate) is a good reference for what one should look like.

Note lineage2's seeded value is capitalised (lineage2_Unknown) unlike every other plugin — worth normalising to lowercase in the same pass, or the file has to match the odd casing.

Asset hygiene found in the same audit

Minor, non-blocking, can ride along:

• bbguildwow/images/roster_classes/: wow_demon_hunter.fw.png and wow_demon_hunter.fw2.png (working files next to the real wow_demon_hunter.png)
• bbguildwow/images/race_images/wow_pandaren_male.jpg — the only .jpg in a PNG set, 36x36 against the set's 24x24
• bbguildlotro/images/race_images/lotro_man_bree.png — no seeded race references it (the installer seeds lotro_man)

[avandenberghe]

Status 2026-09-24: the class_images/ column is complete, the roster_classes/ column is not

All nine plugins now ship their class_images/<game>_unknown.png on main:

Plugin	class_images/	roster_classes/
bbguildeq	✅ 30x30 (#9)	—
bbguildeq2	✅ 38x38 (#9)	—
bbguildffxi	✅ 17x25 (#7)	— (directory still absent, bbguildffxi#6)
bbguildffxiv	✅ 24x24 (#10)	✅ 40x40 on the set's plate (#10)
bbguildgw2	✅ already shipped	—
bbguildlineage2	✅ 30x30 (#9)	—
bbguildlotro	✅ 48x48 (#9)	—
bbguildswtor	✅ 44x44 (#8)	—
bbguildwow	✅ already shipped	✅ already shipped

What that achieves: #389's fallback chain ends at <game>_unknown.png, and that last step could previously almost never fire — it was present in 1 of 9 plugins. It now always resolves, so an unmappable class renders a placeholder rather than nothing.

Design: a ? glyph in warm gold with a dark outline, legible on both light prosilver and dark styles, authored at each set's own size (drawn at 8x and downsampled; box-filtered for FFXIV to match that plugin's pipeline). It follows the convention the family already had — bbguildwow's wow_unknown is a red ? on a plate, bbguildlotro's race unknown a grey ? on gold.

Each PR also added a *_icon_coverage_test to its plugin (six had none): they parse the installer's seeded imagename values and assert both icon directories cover them, with remaining gaps listed in code. So a future gap fails CI rather than going unnoticed.

Why this issue stays open

The roster_classes/ column is deliberately unfinished. Those directories hold large character artwork — 184x184 (wow), 125x184 (eq), ~130x180 (gw2), ~100x100 (lineage2), 100x100 (swtor), 80x80 (lotro), ~80x85 (eq2) — and a scaled-up ? plate at that size would read as fake character art rather than a placeholder. The fallback resolves to the class_images/ icon instead, which is the correct outcome. bbguildffxiv is the exception: its roster set is a 40x40 icon-on-plate, which a placeholder fits natively, so it got both.

So what's left here is a decision, not a task: either close this as done-by-design (the chain always resolves, the large-art placeholders are unwanted), or narrow it to "author roster_classes/ unknown artwork" and keep it with the rest of the artwork backlog.

Not done: normalising bbguildlineage2's capitalised lineage2_Unknown seed to lowercase, as this issue suggests. The shipped filename matches the seeded value exactly (case matters on Linux hosts); changing the seed is a data change needing a migration, so it wants its own issue rather than riding along with an asset fix.