docs: record the icon artwork sourcing decision - #393
Merged
Merged
Conversation
The roadmap asked how the ~168 remaining icon assets should be sourced; decided 2026-09-24: community wikis, with attribution. Alternatives considered were commissioning (~168 pieces across 9 visual styles), client extraction, and closing the tickets in favour of #389's fallback. New "Icon artwork sourcing" section records the decision plus what it obliges, because the wikis are a discovery route and not a licence: a class icon on a fan wiki is the publisher's asset, and a wiki's CC-BY-SA text licence does not cover it. So each batch checks the publisher's fan-content policy and the wiki's own image terms, and records provenance in a per-plugin contrib/ATTRIBUTION.md — these repos are GPL-2.0, and third-party art that isn't GPL-compatible must be identifiable rather than implied to be covered by the repo licence. Authored placeholders stay the answer where provenance is unclear, and are the only option for #391's <game>_unknown.png regardless. Next steps item 3 now sequences the work smallest-set-first instead of restating the question, and notes that the tests added 2026-09-24 already pin sizes and filenames, so a mis-sized batch fails CI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bookkeeping only — no code or asset changes. Follows #392, which left "how does the remaining artwork get sourced" as an open question.
Decision: community wikis, with attribution. Alternatives considered: commissioning an artist (~168 pieces across 9 visual styles), extracting from game clients, or closing the artwork tickets and relying on #389's fallback chain.
What the new section records
The scale: ~168 assets — bbguildlineage2 122, bbguildffxi 26, bbguildffxiv 10, bbguildlotro 5, bbguildeq2 2, bbguildgw2 2, bbguildswtor 1, plus the 9
<game>_unknown.png(#391). GW2's render service and XIVAPI are exhausted; nothing upstream covers the rest.And the part that matters most — a wiki is a discovery route, not a licence. A class icon on a fan wiki is almost always the publisher's copyrighted game asset, and the wiki's CC-BY-SA text licence does not extend to it. So each batch, before anything is pulled:
contrib/ATTRIBUTION.md: wiki, owning publisher, policy relied on. These repos are GPL-2.0, so third-party art that isn't GPL-compatible has to be identifiable rather than implied to be covered by the repo licenceCandidate sources are listed per game as candidates to verify, deliberately not as settled licensing claims.
Also
Next steps item 3 now sequences the work smallest-set-first (
<game>_unknown.png→ swtor/eq2/gw2/lotro/ffxiv → ffxi → lineage2 last) instead of restating the question, and notes that the dimension and coverage tests added 2026-09-24 already pin sizes and filenames — so a batch that lands mis-sized or misnamed fails CI instead of shipping crooked.🤖 Generated with Claude Code