Fix roster icon filename casing, drop a non-existent class (#7) - #8
Merged
Merged
Conversation
roster_classes/ mixed capitalised filenames into an otherwise lowercase set, so the roster grid — which builds its path from the installer's imagename value — could not resolve them: - eq2_Coercer.png -> eq2_coercer.png - eq2_Warden_small.png -> eq2_warden.png - eq2_Captain.png removed: EQ2 has no Captain class and no seeded imagename references it (Captain is a LOTRO class); it was dead weight Beastlord and Channeler are still missing their roster artwork, so #7 stays open for those two. Refs #7 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7 — partial: the naming half. Kept open for the two missing assets.
roster_classes/mixed capitalised filenames into an otherwise lowercase set, so the roster grid — which builds its path from the installer'simagenamevalue — could not resolve them:eq2_Coercer.png→eq2_coercer.pngeq2_Warden_small.png→eq2_warden.pngeq2_Captain.pngremoved — EQ2 has no Captain class and no seededimagenamereferences it (Captain is a LOTRO class); it was dead weightStill open on #7
Beastlord and Channeler have no roster artwork. The issue suggested copying from
class_images/, but that won't work:roster_classes/holds large character renders (~80x85 here) while those twoclass_images/sources are 18x20 and 17x20 detail icons — upscaling them would look wrong next to the rest of the grid. They need real artwork.With avathar/bbguild#389 merged, both now fall back to the
class_images/icon rather than rendering broken.🤖 Generated with Claude Code