Skip to content

roster_classes/ directory missing entirely, plus 3 missing class icons #6

Description

@avandenberghe

Summary

Two gaps found during the 2.2.0 icon audit. bbguildffxi had no icon ticket at all, so neither was tracked.

1. images/roster_classes/ does not exist

All 23 classes seeded by game/ffxi_installer.php reference it — the roster grid resolves roster_classes/<imagename>.png — so the grid has never had a class icon for this game. Every other game plugin ships this directory.

For reference, the other plugins' roster_classes/ art is large character renders rather than icons (eq ~125x184, gw2 ~130x180, swtor 100x100, lotro 80x80, wow 184x184), so this is an artwork task, not a copy of class_images/.

2. images/class_images/ is missing 3 of 23

  • ffxi_geomancer.png
  • ffxi_rune_fencer.png
  • ffxi_unknown.png (referenced by class_id 0)

Geomancer and Rune Fencer are both Seekers of Adoulin jobs that are seeded but have no icon. The existing 20 are 16-18px wide by 25-26px tall — not square, and not uniform.

Impact

With avathar/bbguild#389 merged, the grid now falls back to class_images/ for the 20 classes that have one, and renders nothing for the other 3 — instead of 23 broken images. So this is a quality gap rather than a visible breakage.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions