Skip to content

spec_catalog() is missing 9 elite specializations #12

Description

@avandenberghe

Summary

game/gw2_provider.php::spec_catalog() holds 27 elite specs — three per profession. The official API (https://api.guildwars2.com/v2/specializations?ids=all) currently returns 36, one more per profession:

Profession Missing spec
Warrior Paragon
Guardian Luminary
Engineer Amalgam
Ranger Galeshot
Thief Antiquary
Elementalist Evoker
Mesmer Troubadour
Necromancer Ritualist
Revenant Conduit

Found while wiring the icon assets in #8 — the icons for these nine were deliberately left out of that PR because adding the specs themselves is a data decision, not an asset one.

What's needed

For each of the nine: a role_id (this plugin's Damage/Support/Control override, per install_roles()), a spec_order (4, following the existing three), and the icon fetched from the API's render service the same way #8 did — normalised from 64x64 to 56x56 and named <profession>_<spec>.png in images/spec_icons/.

The role assignments are the judgement call: #8's existing 27 were assigned to each spec's primary role in established raid/WvW meta play, which needs someone who follows the current meta rather than a mechanical mapping.

test_every_elite_spec_has_an_icon_asset() (added in #8) will fail the moment a spec is added without its icon, so the asset half can't be forgotten.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions