Remove stray lineage2_hwarrior.jpg (#3) - #8
Merged
Merged
Conversation
class_images/ carried both lineage2_hwarrior.jpg and the .png the installer actually references. The icon set is PNG-only by convention, so the duplicate .jpg is removed. The 12 missing starter-class icons are unaffected, so #3 stays open. Refs #3 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3 — the stray-file half only. Kept open for the missing icons.
class_images/carried bothlineage2_hwarrior.jpgand the.pngthe installer actually references. The icon set is PNG-only by convention, so the duplicate.jpgis removed — the issue notes this explicitly.Still open on #3 / #7
The 12 missing starter-class icons (
lineage2_hfighter,lineage2_hmystic,lineage2_efighter, …,lineage2_Unknown) need real 30x30 artwork, and #7's 110 missingroster_classes/portraits need artwork at roughly 100x100.With avathar/bbguild#389 merged, #7's impact is contained: every class now falls back to its
class_images/icon instead of rendering a broken image, which is why filling 110 portraits is no longer urgent.🤖 Generated with Claude Code