Add the authored lotro_unknown.png placeholder (#3) - #9
Merged
Merged
Conversation
class_id 0 — the class a character gets when a sync cannot map it — has always seeded this imagename with no file behind it, so it rendered as a broken image until avathar/bbguild#389 added a fallback chain. That chain ends at <game>_unknown.png, so without this file its last step could never fire. Authored rather than sourced: no wiki or API has a generic "unknown class" icon, which is why avathar/bbguild#391 calls these out as the one part of the icon backlog that placeholders are the right answer for. A '?' glyph matches what the family already does here (bbguildwow's wow_unknown is a red '?' on a plate, bbguildlotro's race unknown a grey '?' on gold). Warm gold with a dark outline, so it stays legible on both light prosilver and dark styles; drawn at 8x and downsampled; 48x48 to match the set. lotro_icon_coverage_test parses the installer's seeded imagename values and asserts both icon directories cover them, with the remaining gaps listed explicitly — so a new gap fails CI instead of going unnoticed. Refs #3 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3 — the
lotro_unknown.pngthe issue lists as missing. Adds it toclass_images/at 48x48, matching the set as normalised in #8.Style note:
race_images/lotro_unknown.pngalready existed (a grey?on the race set's gold plate) and is part of what the glyph design here follows.Still open on #3:
lotro_brawlerandlotro_marinerclass icons,lotro_hobbit_riverrace icon, and the 10 classes with noroster_classes/artwork.Why authored rather than sourced
class_id0 — what a character gets when a sync cannot map its class — has always seeded thisimagenamewith no file behind it. avathar/bbguild#389 added a fallback chain that ends at<game>_unknown.png, so without this file its last step could never fire.No wiki or API has a generic "unknown class" icon, which is exactly why avathar/bbguild#391 singles these out as the one part of the icon backlog where authored placeholders are the right answer rather than a stopgap. This follows the roadmap's sourcing policy (avathar/bbguild#393): authored placeholders where no provenance exists.
Design
A
?glyph, matching what the family already does here — bbguildwow'swow_unknownis a red?on a plate, bbguildlotro's race unknown a grey?on gold. Warm gold with a dark outline so it stays legible on both light prosilver and dark styles (pbwow3), drawn at 8x and downsampled.Test
The new
*_icon_coverage_testparses the installer's seededimagenamevalues and asserts both icon directories cover them, listing the remaining gaps explicitly — so a new gap fails CI instead of going unnoticed, and the known ones are documented in code rather than only in tickets.🤖 Generated with Claude Code