Normalise undersized race icons to the set's 44x44 (#3) - #7
Merged
Merged
Conversation
Togruta and Nautolan (male and female) shipped at 20x20 against every other race icon's 44x44, so those rows misaligned — the roster renders these files at their natural size, with no width/height attributes. Each is centred on a transparent 44x44 canvas rather than upscaled: the original pixels stay crisp and the change is reversible, at the cost of the artwork still reading smaller than its neighbours. Replacing them with real 44x44 art remains the better fix. test_race_images_are_all_44x44 / _class_images_ guard both sets against another odd-sized icon slipping in. swtor_unknown.png (class_id 0) is still missing, so #3 stays open. Refs #3 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3 — the size half. Kept open for the missing
swtor_unknown.png.Togruta and Nautolan (male and female) shipped at 20x20 against every other race icon's 44x44. The roster renders these files at their natural size with no
width/heightattributes, so those rows misaligned.Approach
Each of the four is centred on a transparent 44x44 canvas, not upscaled. The issue asks for them "recreated at 44x44 in the same style", which resampling can't honestly deliver — a 20x20 source blown up to 44x44 is visibly soft next to native 44px art. Padding keeps the original pixels crisp and is fully reversible; the tradeoff is that the artwork still reads smaller than its neighbours. Real 44x44 art is still the better fix, which is why this is
Refs, notCloses.Tests
swtor_icon_dimensions_testguards bothrace_images/andclass_images/at 44x44, so another odd-sized icon can't slip in unnoticed.Still open on #3
class_images/swtor_unknown.png(referenced byclass_id0) doesn't exist. There's no official source to pull it from, unlike the GW2 spec icons — it needs authoring. With avathar/bbguild#389 merged,class_id0 now renders no image rather than a broken one.🤖 Generated with Claude Code