Skip to content

Update URI scheme used by SQL Server artifact repo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbczumar wants to merge 2 commits into
base: dbArtifactStore
Choose a base branch
from
Open

Update URI scheme used by SQL Server artifact repo #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41b3960
Tweak URI
dbczumar Dec 13, 2019
c8f2bb5
Simplify
dbczumar Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions mlflow/store/artifact/db_artifact_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
import os
import posixpath
from abc import ABCMeta
import sqlalchemy
import tempfile
Expand Down Expand Up @@ -47,26 +48,17 @@ def extract_db_uri_and_root_path(repo_uri):
error_msg = "Invalid database scheme in the URI: '%s'. %s" % (scheme, _INVALID_DB_URI_MSG)
raise MlflowException(error_msg, INVALID_PARAMETER_VALUE)

if parsed_uri.query == "":
if parsed_uri.path == "":
return repo_uri, ""
else:
parsed_path = parsed_uri.path.split(ROOT_PATH_BASE, 1)
if len(parsed_path) == 2:
db_uri = os.path.dirname(os.path.dirname(repo_uri))
path = os.path.normpath(repo_uri.split(db_uri)[1])
path = path.split(os.sep, 1)[1]
return db_uri, path
else:
return repo_uri, ""
else:
parsed_query = parsed_uri.query.split("/", 1)
if len(parsed_query) == 2:
path = os.path.normpath(parsed_query[1])
parsed_uri = parsed_uri._replace(query=parsed_query[0])
else:
path = ""
return urllib.parse.urlunparse(parsed_uri), path
def get_dbname_and_path(uri_path):
head, tail = posixpath.split(uri_path)
if len(head) == 0 or head == posixpath.sep:
return tail, posixpath.sep

dbname, path = get_dbname_and_path(head)
return dbname, posixpath.join(path, tail)

dbname, artifact_path = get_dbname_and_path(parsed_uri.path)
parsed_root_uri = parsed_uri._replace(path=dbname)
return urllib.parse.urlunparse(parsed_root_uri), artifact_path


class DBArtifactRepository(ArtifactRepository):
Expand Down