add Fifo.length function#8
Open
fredcy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My app frequently wants to know the length of the Fifo (for display to the user) and the Fifo can grow to be thousands of items long, so I want a fast way to obtain that length value. I could use
Fifo.toList |> List.lengthbut that involves both list reversal (within toList) and traversal again (in List.length) on each call.So this change has the Fifo keep its current length as part of the state. This does mean additional work on every
insert,remove, andtoListcall to recalculate that length. I have not benchmarked any times before and after this change.If this PR is unacceptable, please let me know and I'll probably publish my forked version as a new package.