Skip to content

Mission Control P1: quick assign UI + remove AC1 dynamic skip#153

Closed
krusty-agent wants to merge 5 commits intoaviarytech:mainfrom
krusty-agent:feat/mission-control-ac1-assign-ui
Closed

Mission Control P1: quick assign UI + remove AC1 dynamic skip#153
krusty-agent wants to merge 5 commits intoaviarytech:mainfrom
krusty-agent:feat/mission-control-ac1-assign-ui

Conversation

@krusty-agent
Copy link
Collaborator

@krusty-agent krusty-agent commented Mar 3, 2026

Summary

  • Add a quick Assign control on list items to support Mission Control assignee workflows directly from list view
  • Wire quick assign action to api.items.updateItem (assigneeDid = userDid)
  • Show lightweight assignment feedback text (Assigned) after mutation success
  • Update e2e/mission-control-phase1.spec.ts AC1 to remove feature-gated dynamic skip and assert assign control visibility
  • Wire list-level collaborator presence in ListView using Convex presence heartbeat/offline mutations + presence.getListPresence
  • Add a visible session indicator chip in list header: 👀 {n} viewing now
  • Remove AC3 feature-gated dynamic skip (hasPresenceUi) from e2e/mission-control-phase1.spec.ts

Why

Mission Control tracker called out assignee/activity/presence wiring and dynamic skip removals. This PR now covers AC1 + AC2/AC5b test-path cleanup + AC3 presence wiring in the app shell.

Test Evidence

Prior targeted run (already in branch)

npm run test:e2e -- e2e/mission-control-phase1.spec.ts -g "baseline harness boots app shell|AC1 assignee round-trip"

Result:

  • 1 passed (baseline harness boots app shell)
  • 1 skipped (AC1 assignee round-trip) due existing environment auth/app-shell readiness gate
  • 0 failed

New targeted run for AC3

npm run test:e2e -- e2e/mission-control-phase1.spec.ts -g "AC3 presence freshness"

Result:

  • 0 passed
  • 1 skipped (AC3 presence freshness) due existing environment auth/app-shell readiness gate (openAuthenticatedApp)
  • 0 failed

The AC3 feature availability skip has been removed; remaining skip is environment readiness only.

@krusty-agent
Copy link
Collaborator Author

Progressing next P0 task: Phase 1: Unskip Mission Control e2e tests with seeded auth fixtures.\n\nWhat changed in :\n- Reworked AC2 harness to use existing item-details activity surface (no feature-flag skip for missing Activity button).\n- Reworked AC5b perf harness to measure item-details activity open latency directly (removed dynamic skip tied to Activity button existence).\n- Added helper for deterministic item-details modal open checks.\n\nTargeted validation:\n\n\n\nResult: \n- Baseline passed\n- Remaining skips are environment auth-shell readiness gate (), not missing Activity button wiring.

@krusty-agent
Copy link
Collaborator Author

Progressing next P0 task: Phase 1: Unskip Mission Control e2e tests with seeded auth fixtures.

What changed in commit e9cad52:

  • Reworked AC2 harness to use existing item-details activity surface (no feature-flag skip for missing Activity button).
  • Reworked AC5b perf harness to measure item-details activity open latency directly (removed dynamic skip tied to Activity button existence).
  • Added helper for deterministic item-details modal open checks.

Targeted validation:

npm run test:e2e -- e2e/mission-control-phase1.spec.ts -g "baseline harness boots app shell|AC2 activity log completeness|AC5b perf floor harness"

Result: 1 passed, 2 skipped

  • Baseline passed
  • Remaining skips are environment auth-shell readiness gate (openAuthenticatedApp), not missing Activity button wiring.

@krusty-agent
Copy link
Collaborator Author

Superseded by consolidated PR #167: #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant