Phase 1: ship presence heartbeat expiry (<=90s)#158
Closed
krusty-agent wants to merge 2 commits intomainfrom
Closed
Phase 1: ship presence heartbeat expiry (<=90s)#158krusty-agent wants to merge 2 commits intomainfrom
krusty-agent wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expiresAton each heartbeat and on offline mark to guarantee stale presence cut-off <=90sgetListPresenceresponses so stale sessions no longer show up in list presence indicatorspresence.expiresAt+by_expires_atindexValidation
npm run test:e2e -- e2e/mission-control-phase1.spec.ts -g "AC3 presence freshness"npx convex codegenNo CONVEX_DEPLOYMENT set)Notes