fix(ui): unblock Cloudflare Pages build (eslint 10 peer conflict) - #24
Closed
adityak74 wants to merge 1 commit into
Closed
fix(ui): unblock Cloudflare Pages build (eslint 10 peer conflict)#24adityak74 wants to merge 1 commit into
adityak74 wants to merge 1 commit into
Conversation
…r range Dependabot bumped eslint to ^10.8.1 in ui/ while leaving eslint-plugin-react-hooks at ^7.0.1, whose peer range stops at eslint 9. npm ci then fails with ERESOLVE, so the Cloudflare Pages build never reaches the build step. eslint-plugin-react-hooks 7.1.1 widens its peer range to include ^10.0.0. typescript-eslint 8.67.0 and eslint-plugin-react-refresh 0.4.24 already accept eslint 10, so this is the only change needed. Verified against origin/main: npm ci, npm run build, and the root package build all succeed.
Deploying open-context with
|
| Latest commit: |
09bb830
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ae38586.open-context.pages.dev |
| Branch Preview URL: | https://fix-pages-build-eslint-peer.open-context.pages.dev |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Cloudflare Pages build is failing on
main. It never reaches the build step — it dies during dependency install.Reproduced locally against
origin/main(018a6fc):Root cause
A Dependabot bump moved
ui/toeslint@^10.8.1, but lefteslint-plugin-react-hooksat^7.0.1, whose peer range stops at eslint 9:npm cirefuses the install, so Pages fails beforevite buildruns.Fix
Bump
eslint-plugin-react-hooksto^7.1.1. That is the whole change.I checked the rest of the eslint stack rather than bumping blindly — nothing else needed changing:
typescript-eslint@8.67.0^8.57.0 || ^9.0.0 || ^10.0.0eslint-plugin-react-refresh@0.4.24>=8.40eslint-plugin-react-hooks@7.0.1… || ^9.0.0Verification
Run against
origin/mainwith this patch applied:cd ui && npm ci— succeeds (was the failing step)cd ui && npm run build—tsc -b && vite build, built in 357msnpm ciat repo root — succeedsnpm run buildat repo root — succeedsNote on lint (not addressed here, and not blocking)
npm run lintreports errors, but this is pre-existing and unrelated to the deploy:origin/main(forced install via--legacy-peer-deps): 27 errorsThe 5 additional errors come from new rules shipped in react-hooks 7.1.x (
react-hooks/immutability,react-hooks/error-boundaries), not from anything this PR changes in application code.Lint is not part of the Pages build (
npm run buildistsc -b && vite build) and there is no lint CI workflow, so none of this blocks the deploy. Worth a separate cleanup PR — deliberately left out of this one to keep the deploy fix minimal and easy to review.