docs: say the MSRV the manifest actually declares - #84
Merged
Conversation
Both instruction files said MSRV is 1.82. The root Cargo.toml has said 1.95 since the dependency tree walked past 1.82, and the msrv CI job pins that exact toolchain, so the docs have been wrong rather than merely out of date: 1.82 has not built this workspace for a while. This is not a harmless stale number. It is the line an agent reads before deciding whether a standard library API is available, and a floor stated thirteen versions too low steers work away from things that are in fact usable. It cost a real detour on the on-device search branch, where as_chunks, stable since 1.88, looked out of reach. Both files carry the same wording, which is the rule for this pair, and the new text points at the manifest as the answer so the next drift is a doc bug and not a mystery. Claude-Session: https://claude.ai/code/session_01KGPVQ8wUG7h36zashWYCp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE.mdandAGENTS.mdboth said MSRV is 1.82. The rootCargo.tomlsaysrust-version = "1.95", and themsrvCI job pins thatexact toolchain.
The manifest is right and the docs were wrong. This is not a number that
drifted ahead of reality; 1.82 has not built this workspace for a while. The
msrvjob's own comment records why it exists:That job was added to stop the manifest drifting. Nobody updated the two
files that repeat the number in prose.
Why this one is worth a commit
It is the line somebody reads before deciding whether a standard library API
is available to them. A floor stated thirteen versions too low steers work
away from things that are in fact usable, and it does so invisibly, because
the wrong answer still compiles.
It already cost something. On the on-device search branch,
slice::as_chunkslooked out of reach and an
#[allow]looked like the safer option. It hasbeen stable since 1.88, comfortably under the real floor, and the direct fix
was available the whole time.
The change
Both files get the same replacement, which is the standing rule for this
pair. The new wording names
rust-versionand themsrvjob as the sourceof truth and says to read the manifest if the two ever disagree again, so the
next drift is a doc bug somebody can spot rather than a mystery.
Documentation only. No code, no manifests, no CI.
https://claude.ai/code/session_01KGPVQ8wUG7h36zashWYCp4