Skip to content

0.8.3: Add an experimental feature to directly encode - #254

Merged
j6carey merged 48 commits into
masterfrom
direct-encoding
Mar 18, 2025
Merged

j6carey merged 48 commits into
masterfrom
direct-encoding

Conversation

@j6carey

@j6carey j6carey commented Aug 17, 2024

Copy link
Copy Markdown
Collaborator

...without using intermediate data structures.

Also add --stringType as a preferred spelling of --string-type,
and fix a bug in the encoding of packed "sint32" fields that harmed
forward compatibility with "sint64" and increased message sizes.

...without using intermediate data structures.

Also add --stringType as a preferred spelling of --string-type,
and fix a bug in the encoding of packed "sint32" fields that harmed
forward compatibility with "sint64" and increased message sizes.
...at the expense of some ambiguity in the type parameters of classes.

Also expand test coverage.
Also reorganize Repetition and rename Encoding to MessageEncoding.
Previously we would be left with unreduced type family applications instead.
@j6carey j6carey changed the title Add an experimental feature to directly encode 0.8.3: Add an experimental feature to directly encode Mar 18, 2025
@j6carey
j6carey merged commit e72d4cc into master Mar 18, 2025
@j6carey
j6carey deleted the direct-encoding branch March 18, 2025 22:09
Comment thread proto3-suite.cabal Outdated
pretty ==1.1.*,
pretty-show >= 1.6.12 && < 2.0,
proto3-wire >= 1.2.2 && < 1.5,
proto3-wire >= 1.4.4 && < 1.5,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest on hackage is 1.4.3, I think this broke cabal build

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest on hackage is 1.4.3, I think this broke cabal build

Thanks for letting us know. I uploaded proto3-wire-1.4.4 and will get the rest of the versions missing packaged and published shortly.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 1.4.4 and 1.4.5 have been released, which allowed me to fix the proto3-suite build in nixpkgs against 1.4.4 with NixOS/nixpkgs#458271 by pointing proto3-suite at #274. Thanks for that.
Ideally we could just use the hackage release, but latest for proto3-suite is 0.7.0, too far behind to even allow comfortably cherry-picking select commits (e.g. bounds) without conflicts.

Note nixpkgs relies on a couple proto3-wire overrides which are needed until a release of current master:

I noticed you use nixpkgs here as well. In case you're unaware, haskellPackages get most versions from stackage LTS, so it's often the same work getting proto3-* available on both rather than just one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants