Skip to content

[WIP] Add flake8 and vim configs#466

Open
rfleschenberg wants to merge 1 commit into
awesto:masterfrom
rfleschenberg:flake8-config
Open

[WIP] Add flake8 and vim configs#466
rfleschenberg wants to merge 1 commit into
awesto:masterfrom
rfleschenberg:flake8-config

Conversation

@rfleschenberg

@rfleschenberg rfleschenberg commented Nov 21, 2016

Copy link
Copy Markdown
Member
  • Add flake8 config file
  • Test it
  • Add a flake8 check to travis
  • Fix all current flake8 errors

@jrief

jrief commented Nov 22, 2016

Copy link
Copy Markdown
Member

If we add a .flake8 file, shouldn't we also add --flake8 to addopts in pytest.ini?

@rfleschenberg

Copy link
Copy Markdown
Member Author

That would be a possibility. I usually have a flake8 check as a separate step in CI, so that CI can fail early if there are flake8 problems. But I never used py.test with --flake, maybe I should take a look at that.

@rfleschenberg

Copy link
Copy Markdown
Member Author

After a quick look at https://pypi.python.org/pypi/pytest-flake8, I wonder what the benefit of this plugin over just running flake8 directly is.

@jrief

jrief commented Mar 16, 2017

Copy link
Copy Markdown
Member

@rfleschenberg can we close this?

@rfleschenberg

Copy link
Copy Markdown
Member Author

It's ok if you close it, but I'd prefer to keep it open, but as a low-priority, "maybe if I have time" kind of thing :)

@jrief

jrief commented Mar 16, 2017

Copy link
Copy Markdown
Member

About .vimrc:
I'm not very favorable adding IDE/Editor specific stuff to the repository. Each IDE has their own config files and adding all of them can create a mess.
There is one exception to this: .editorconfig which is understood by all major IDEs.

@rfleschenberg

Copy link
Copy Markdown
Member Author

I'd prefer to read these from .editorconfig, unfortunately that's not supported with my current setup. I should probably modernize my Vim setup. Time constraints :(

Comment thread .vimrc
@@ -0,0 +1,4 @@
" Ideally, we would read these from .editorconfig, but Pymode doesn't seem to

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you decide to remove the vim config, then you need to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants