Fixed missing phone number in Django Shop Plugin#863
Open
shivamraj74 wants to merge 1 commit into
Open
Conversation
Missing phone number option in link plugin awesto#861 Django Shop plugin is missing due to overriding the LinkForm.LINK_TYPE_CHOICES property.
Contributor
|
@shivamraj74 I already fixed it bug here #862. I think my solution is more correct since it eliminates duplication of the parent's code. |
Author
|
I think simply eliminating the parent's code, could not arise security issues? |
Contributor
I don't quite understand how this can cause security problems. Please, show me an example. |
Author
|
Well, it was missing due to overriding of class LinkForm property, so I basically corrected at cascade plugin and now let the owner decide it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing phone number option in link plugin #861 Django Shop plugin is missing due to overriding the LinkForm.LINK_TYPE_CHOICES property. By letting add to LinkForm if the phone number exists.