Repository navigation
Conversation
|
The standalone-hosting-nuxt e2e fixture floated its Nuxt toolchain on caret ranges (nuxt ^4.4.5, vue ^3.5.34, vue-router ^5.0.6, @nuxt/image ^2.0.0). The setup copies the fixture to a fresh tmpdir and runs a plain `npm install`, so each CI run could resolve a different nuxt/@nuxt/nitro-server/vue-bundle-renderer combination. A drifted combination made `nuxt build` fail during Nitro prerender of the /about route on the windows-2025 runner (vue-bundle-renderer "Either manifest or precomputed data must be provided"), surfacing as a NitroBuildError before any deploy ran. Pin the four direct deps to exact versions and add a vue-bundle-renderer override. vue-bundle-renderer is the transitive dep implicated in the prerender failure and is pulled with a loose range that pinning nuxt alone does not lock, so the override pins it directly. This keeps the fix to a single reviewable file and relies on the exact pins for deterministic resolution.
sarayev
force-pushed
the
fix/standalone-hosting-nuxt-pin-toolchain
branch
from
October 7, 2026 15:20
40862a7 to
4fee626
Compare
Contributor
Author
|
Reopening from an internal branch (aws-amplify/amplify-backend) instead of my fork so the deployment e2e can obtain the AWS OIDC credentials fork PRs can't get. Same commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
standalone-hosting-nuxte2e fixture floated its entire Nuxt toolchain on caret ranges (nuxt ^4.4.5,vue ^3.5.34,vue-router ^5.0.6,@nuxt/image ^2.0.0). The test setup copies the fixture to a fresh tmpdir and runs a plainnpm install, so each CI run can resolve a differentnuxt/@nuxt/nitro-server/vue-bundle-renderercombination.A drifted combination made
nuxt buildfail during Nitro prerender of the/aboutroute on thewindows-2025runner:The build dies during CDK synth, before any deploy runs, failing the
standalone_hosting_nuxtdeployment e2e (stages 2/2b/2c/2d, and 3's SWR check cascades on the missing URL).Fix
Pin the four direct deps to exact versions and add a
vue-bundle-rendereroverride.vue-bundle-rendereris the transitive dep implicated in the prerender failure, and it is pulled with a loose range that pinningnuxtalone does not lock, so the override pins it directly. This keeps the change to a single reviewable file and relies on the exact pins for deterministic resolution, rather than committing a full lockfile.Verification
package.jsoninstalls andnuxt buildcompletes successfully on Linux (prerender passes, build exits 0).@aws-amplify/integration-testsisprivate, so no changeset is required.windows-2025e2e run to confirm the fix. Opened as draft for that reason.Notes
Unrelated to the backend-deployer release PR #3357 - that failure chain surfaced this pre-existing fixture flake, but the deployer change is never reached (the build fails before deploy).