Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions test/unit/deadline_client/job_bundle/test_repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import sys
import zipfile
from pathlib import Path
from types import SimpleNamespace

import pytest
import yaml
Expand Down Expand Up @@ -1266,14 +1267,19 @@ class TestArchiveExtractionSafety:
counts, and extractions that wouldn't fit on disk — always enforced."""

def _fake_zip(self, entries):
"""entries: list of (file_size, compress_size) tuples."""
"""entries: list of (file_size, compress_size) tuples.

Uses lightweight SimpleNamespace entries rather than MagicMock: the
too-many-entries test builds MAX_ARCHIVE_ENTRIES + 1 (100_001) infos,
and a MagicMock per entry exhausts worker memory (OOM-crashing the
pytest-xdist worker). _check_archive_extraction_safety only reads
.file_size / .compress_size, which SimpleNamespace provides.
"""
zf = MagicMock()
infos = []
for file_size, compress_size in entries:
zi = MagicMock()
zi.file_size = file_size
zi.compress_size = compress_size
infos.append(zi)
infos = [
SimpleNamespace(file_size=file_size, compress_size=compress_size)
for file_size, compress_size in entries
]
zf.infolist.return_value = infos
return zf

Expand Down
Loading