Update trp2.py BaseSchema to exclude unknown fields#193
Open
elanou wants to merge 1 commit intoaws-samples:masterfrom
Open
Update trp2.py BaseSchema to exclude unknown fields#193elanou wants to merge 1 commit intoaws-samples:masterfrom
elanou wants to merge 1 commit intoaws-samples:masterfrom
Conversation
…ct model don't cause marshmallow validation errors and kill existing functionality of this library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #192
Right now the
TDocumentSchemais unusable due to textract outputting new fields that are "unknown" to the nestedTGeometrySchema.This fix applies the option to exclude unknown fields to the
BaseSchemawhich the others inherit from. This will fix the current issue and prevent this from happening in the future where textract model updates are not immediately captured in this library.There should probably be another PR for adding support for
RotationAnglein the geometry schema.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.