This repository was archived by the owner on Sep 13, 2024. It is now read-only.
Add GO111MODULE=on to honnef.co/go/tools/cmd/staticcheck - #504
Merged
Conversation
angelcar
approved these changes
May 3, 2022
sparrc
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
GO111MODULE=onto honnef.co/go/tools/cmd/staticcheck to makemake get-depshappy in the PR CI build checks. Sample PR where this check failed - #503Identical to aws/amazon-ecs-agent#3193
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: