Add ML-DSA aarch64 native assembly to CC builder scripts#1113
Open
jakemas wants to merge 1 commit into
Open
Conversation
Discover the `.S` files under `crypto/fipsmodule/ml_dsa/mldsa/native/aarch64/src/` in the same way ML-KEM's aarch64 backend and ML-DSA's x86_64 backend (aws#1110) are already handled. Follows the same pattern as those PRs. ## Context aws/aws-lc#3219 imports the mldsa-native aarch64 backend into aws-lc, adding `.S` files under `crypto/fipsmodule/ml_dsa/mldsa/native/aarch64/src/`. The aws-lc-rs CC builder needs to discover these files, otherwise the `aws-lc-rs-macos` CI job (and any other cc-builder consumer on aarch64) fails to link with undefined symbols for the mldsa aarch64 routines. ## Changes - `linux_aarch64.sh`: add `find` for ML-DSA aarch64 assembly - `apple_aarch64.sh`: add `find` for ML-DSA aarch64 assembly ## Note The generated `.rs` builder files will need regeneration after the aws-lc submodule is bumped to include the ML-DSA aarch64 backend.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
- Coverage 95.80% 92.59% -3.21%
==========================================
Files 61 71 +10
Lines 8143 10177 +2034
Branches 0 10177 +10177
==========================================
+ Hits 7801 9423 +1622
- Misses 342 459 +117
- Partials 0 295 +295 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux_aarch64.shandapple_aarch64.shContext
aws/aws-lc#3219 imports the mldsa-native aarch64 backend into aws-lc, adding
.Sfiles undercrypto/fipsmodule/ml_dsa/mldsa/native/aarch64/src/. The aws-lc-rs CC builder needs to discover these files, otherwise theaws-lc-rs-macosCI job in aws-lc fails with undefined-symbol link errors foraws_lc_*_mldsa_poly_*_asmand friends. This PR unblocks aws/aws-lc#3219.Changes
linux_aarch64.sh: addfindfor ML-DSA aarch64 assemblyapple_aarch64.sh: addfindfor ML-DSA aarch64 assemblyNote
The generated
.rsbuilder files will need regeneration after the aws-lc submodule is bumped to include the ML-DSA aarch64 backend.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.