Fixes for build on Windows #193
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h separators Signed-off-by: Rossi, Davide <Davide.Rossi@hilti.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this branch over to the current repo with some additional proposed fixes for our Windows users. This was originally committed via: awslabs/amazon-neptune-tools#202
Still needs to address how the --strict-cardinality flag may get applied. The original proposal changes the default behavior.
Most of the changes in these commits involve issues with Windows line separators not properly being evaluated in various tests when the JAR is compiled.
There's also an issue with the export-to-Kinesis support for Windows. The KPL is no longer supported on Windows after version 0.14.0. And KPL version > 1.0 is needed to for AWS Java SDK v2 support. This creates an issue were we cannot support builds with the KPL tests on Windows. Likely that using export to Kinesis will not work on Windows, either.