Skip to content

fix: keep route scope tabs visible - #790

Merged
awsl233777 merged 1 commit into
mainfrom
fix-route-scope-bar-visibility
Aug 6, 2026
Merged

fix: keep route scope tabs visible#790
awsl233777 merged 1 commit into
mainfrom
fix-route-scope-bar-visibility

Conversation

@awsl233777

@awsl233777 awsl233777 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep the global/project scope tab bar visible even when projects are still loading or the project list is empty
  • show a stable Projects placeholder instead of removing the whole scope row
  • reset the selected route scope back to Global if the previously selected project no longer exists

Validation

  • cd web && pnpm typecheck && pnpm lint
  • git diff --check

Notes

Summary by CodeRabbit

  • 新功能
    • 项目查询期间新增加载状态提示。
    • 当当前选中的项目被删除时,自动回退至全局项目。
    • 路由标签栏始终显示:无项目时展示加载中或暂无项目提示,并保留排序按钮。
    • 有可用项目时显示对应的项目标签。
  • 界面优化
    • 项目悬浮面板仅在存在项目时显示,避免无内容面板占位。

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 659b6464-21b8-4189-9c4b-faf05f7dbcf4

📥 Commits

Reviewing files that changed from the base of the PR and between df88cf9 and 86ed86d.

📒 Files selected for processing (1)
  • web/src/pages/client-routes/index.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: Backend Checks
  • GitHub Check: Frontend Checks
  • GitHub Check: playwright
  • GitHub Check: e2e
🔇 Additional comments (1)
web/src/pages/client-routes/index.tsx (1)

147-147: LGTM!

Also applies to: 176-185, 305-370


📝 Walkthrough

Walkthrough

项目路由页面新增项目加载状态和选择有效性校验。导航标签栏始终显示,并区分加载中、无项目和有项目状态。悬浮项目面板仅在存在项目时显示。

Changes

项目路由状态与导航

Layer / File(s) Summary
项目状态与选择回退
web/src/pages/client-routes/index.tsx
读取 isProjectsLoading。当已选项目不存在且当前选择不是全局项目时,重置为全局项目。
项目导航显示
web/src/pages/client-routes/index.tsx
始终渲染导航区域。无项目时显示加载或空项目提示,并保留排序按钮。有项目时显示全局和项目标签。项目悬浮面板仅在存在项目时渲染。

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Poem

小兔看到标签栏,
加载时刻不隐藏。
项目删除有回退,
空空页面也清爽。
排序按钮仍在旁,
蹦跳庆祝改动忙。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了路由范围标签栏始终可见这一主要变更。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-route-scope-bar-visibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@awsl233777
awsl233777 merged commit 03d018f into main Aug 6, 2026
6 checks passed
@awsl233777
awsl233777 deleted the fix-route-scope-bar-visibility branch August 6, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant