Draft
Conversation
richarddavison
force-pushed
the
feat/fetch-body-streams
branch
from
a3793ae to
ac77021
Compare
Contributor
|
I think it might work with the same feature name if you move |
llrt_modules is already built with proper features (including compression) in the 'Run build all' step. Building it in the per-crate loop with default features fails because llrt_zlib now has default-features=false and needs an explicit compression feature from the parent.
Fixes undefined reference to __imp__vsnprintf when linking the test binary on windows with MinGW + OpenSSL. The new compression dependencies in llrt_fetch change the link graph enough to expose this known MinGW compatibility issue.
richarddavison
force-pushed
the
feat/fetch-body-streams
branch
from
58a8e00 to
612b08b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Fixes: #946
Description of changes
Implements full support for web streams in request and response classes for fetch. Performance is also great
Results from
benchmarks/fetch-streaming.mjsChecklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.