OCaml version robustness and more refined exception traps#357
Open
jargh wants to merge 3 commits into
Open
Conversation
Replace newer OCaml library functions (Option.*, List.filter_map, List.concat_map, List.is_empty, String.starts_with/ends_with, Int.logand/shift_right/shift_left) with equivalents available in OCaml 4.05. Add compatibility shims in common/for_hollight.ml. Fix camlp5 parse errors: remove return type annotations on fun expressions in elf.ml and safety.ml, replace `let open Compute in` with top-level `open Compute` in arm/proofs/decode.ml. Fix non-exhaustive pattern match in misc.ml CONS_TO_APPEND_CONV that raised Match_failure uncaught by `with Failure _`. Replace `with _ ->` exception handlers with `with Failure _ ->` throughout to avoid inadvertently catching Sys.Break and other non-Failure exceptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit message. This was entirely written by Claude.