Additional general-size modulus operations for secp256k1#358
Open
jargh wants to merge 9 commits into
Open
Conversation
Add bignum_mod_p256k1 (field characteristic reduction) and bignum_mod_n256k1 (group order reduction) for secp256k1, supporting arbitrary input sizes via iterative long division. Includes ARM assembly, HOL Light formal proofs, tests, and benchmark hooks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HOL Light formal verification proofs for the x86-64 implementations of reduction modulo the secp256k1 field characteristic (p_256k1) and group order (n_256k1). Both proofs cover standard and Windows ABI variants with IBT/non-IBT subroutine wrappers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude eventually converged on something correct, I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a direct response to issue #356, addressing one of several items raised there.
The "co-authored by" in the commit messages is false modesty - code and proofs were 100% written by Claude.