Conversation
added 2 commits
July 20, 2012 20:42
make main function in main (though naoko.main.main() is kind of silly. make a launcher external to the naoko package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this running naoko is a bit of a pain for windows users, I made a simple build script for this. cx_freeze is kind of gross in that it has a bunch of scattered files but it's less hacky than py2exe.
Also the way imports were handled in the naoko.lib modules weren't very conducive to packaging, so I split out a launcher into the top level directory, and used relative imports. You may want to tweak the names a bit.