Repository navigation
Upgrade TypeScript to 6.0 - #28
Closed
kac-axelor wants to merge 1 commit into
Closed
kac-axelor wants to merge 1 commit into
kac-axelor wants to merge 1 commit into
Conversation
TS 6.0 no longer auto-includes node_modules/@types, so declare types: ["node"] explicitly for the Buffer/process/node:* usage.
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
typescript^5.9.3 → ^6.0.3.The only change 6.0 forces on this repo is
types: ["node"]in tsconfig — 6.0 stops auto-including everything undernode_modules/@types, and the source relies on @types/node (Buffer,process,node:*modules). The config was already compliant otherwise:module: ESNextwith bundler resolution, explicitstrictand interop flags, no removed options.Verified:
tscreports the identical four pre-existing errors as under 5.9 (untracked runtime-test issues — two of them are the nested-create sites fixed by the mappedBy PR); unit tests and the rslib build (including d.ts emission) pass unchanged. CI needs no changes.Known behavioral note: 6.0 infers the exact argument shape for generics (microsoft/TypeScript#63515), so unknown keys nested inside where/select/create are silently accepted. This is surfaced by the type tests in #27 and fixed by the follow-up
Options<>guard PR.Series (merge order): #27 type tests (red by design) → #28 TypeScript 6.0 upgrade → #29
Options<>guard fix → #30 mappedBy fix. The suite in #27 goes fully green once all four are merged.