Skip to content

Fix Options<> excess-property guard under TypeScript 6.0 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kac-axelor wants to merge 1 commit into from
Closed

Fix Options<> excess-property guard under TypeScript 6.0 #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/client/types/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,17 @@ export type OmitByType<T, Type> = Pick<
{ [K in keyof T]-?: T[K] extends Type ? never : K }[keyof T]
>;

// TS 6.0 infers the exact argument shape (unknown keys included), so T[K]
// checks a value against itself — excess keys pass. U[K] checks against the
// declared shape instead. The phantom-key branch keeps T[K] referenced so
// TypeScript still infers T and Payload<T,U> still narrows to selected fields.
// https://github.com/microsoft/TypeScript/issues/63515
export type Options<T, U> = {
[K in keyof T]: K extends keyof U ? T[K] : never;
[K in keyof T]: K extends keyof U
? K extends "__use_T_so_it_is_inferred__"
? T[K]
: U[K]
: never;
};

export type OrderBy = "ASC" | "DESC";