Skip to content

we now use GCC for compiling instead of Clang - #6

Merged
inayayousfi merged 1 commit into
releasefrom
main
Dec 30, 2025
Merged

inayayousfi merged 1 commit into
releasefrom
main

Conversation

@inayayousfi

Copy link
Copy Markdown
Collaborator

This pull request updates the Windows build workflow for axidev-io to use MinGW-w64 GCC via MSYS2 instead of the previously used LLVM-MinGW toolchain. The changes streamline the build process, clarify architecture support, and ensure proper environment setup for building, testing, and packaging on Windows.

Migration to MinGW-w64 GCC via MSYS2:

  • Updated workflow to use MSYS2 with MinGW-w64 GCC, replacing LLVM-MinGW and its custom installation steps. This includes setting up the appropriate MSYS2 environment and installing required packages for the selected architecture (x86 or x64).
  • Changed shell invocations for build, test, and install steps to use the MSYS2 shell, ensuring commands are executed in the correct environment. [1] [2] [3]

Configuration and Documentation Improvements:

  • Revised the workflow name and description to clarify that it uses MinGW-w64 GCC (linked against libstdc++) rather than LLVM-MinGW.
  • Updated the supported architectures to x86 and x64, removing references to arm64 and LLVM-MinGW version input.

Build Configuration Adjustments:

  • Simplified CMake configuration by removing custom compiler selection logic and defaulting to Ninja generator with MinGW-w64 GCC.
  • Retained static linking of libstdc++ and libgcc to avoid runtime DLL dependencies, updating comments for clarity.

@coderabbitai

coderabbitai Bot commented Dec 30, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@inayayousfi
inayayousfi merged commit 8b17e82 into release Dec 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant