You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
mesh-compile: a partial-turn revolution from revolve_profile_exact is not a closed solid #503
Defect. A partial-turn solid from revolve_profile_exact is not returned as a closed Solid: for example, a 3/4 cylinder or a 3/4 cone. The same happens on main before #463, so poles are not the cause.
Cause, as far as it was traced. The base sector's loop runs clockwise about its plane's normal, while the face is Forward. The planar tessellation path reads the loop winding; the curved path reads only the face orientation. The base is therefore laid the wrong way against the wall's rim, and every open edge lies in the base.
Repro.revolve_profile_exact of a rectangle profile through 3π/2, compiled at 1e-3: the result is not Solid, and its open edges are all in the base sector. crates/execution/compile/tests/pole_faces.rs::three_quarters_of_a_cone_close_at_their_apex (from #463) pins the cone case.
Done when 3/4 cylinders and cones from revolve_profile_exact compile as watertight Solids within their certified bound. That means either the construction emits the base loop consistently with the face orientation, or the curved path honours the loop winding the way the planar path does (decide which in the fix, with a test for each orientation).
Activity