Skip to content

On-Hold Closes #2612 Upgrade cweagans/composer-patches to version 2#3181

Draft
trackleft wants to merge 16 commits intomainfrom
issue-2612-composer-patches-version-2
Draft

On-Hold Closes #2612 Upgrade cweagans/composer-patches to version 2#3181
trackleft wants to merge 16 commits intomainfrom
issue-2612-composer-patches-version-2

Conversation

@trackleft
Copy link
Copy Markdown
Member

@trackleft trackleft commented Feb 16, 2024

Description

This PR upgrades the cweagans/composer-patches package to version 2. This update is necessary to maintain compatibility with the latest composer updates and ensure our patching workflow remains efficient and reliable. The upgrade process involved updating the composer.json file and ensuring all existing patches are still applied correctly.

Related issues

Closes #2612

This PR is blocked by two other PRs:

How to test

  1. Check out this PR.
  2. Run composer update cweagans/composer-patches.
  3. Ensure all patches defined in composer.json are applied without errors.
  4. Test the functionality that relies on patched packages to verify there are no regressions.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons added enhancement New feature or request ci Continuous integration / automation dependencies Pull requests that update a dependency file 2.10.x only labels Feb 16, 2024
@trackleft

This comment was marked as resolved.

@trackleft trackleft marked this pull request as ready for review February 20, 2024 23:42
@trackleft trackleft requested a review from a team as a code owner February 20, 2024 23:42
@trackleft
Copy link
Copy Markdown
Member Author

trackleft commented Feb 20, 2024

Blocked by #3191
Blocked by #3192

Comment thread composer.json Outdated
@joeparsons
Copy link
Copy Markdown
Member

Definitely glad to see this working.

Question: should we wait until a stable release is available before upgrading to 2.x?

@trackleft trackleft changed the title Closes #2612 Upgrade cweagans/composer-patches to version 2 On-Hold Closes #2612 Upgrade cweagans/composer-patches to version 2 Apr 3, 2024
@trackleft
Copy link
Copy Markdown
Member Author

Need to update the google tag patch.

1027
1028In Patches.php line 288:
1029                                                                               
1030  No available patcher was able to apply patch https://www.drupal.org/files/i  
1031  ssues/2024-03-01/3424623-9-allow-saving-google-tag-setting-for-consent-mode  
1032  .patch to drupal/google_tag                                                  
1033                                                                               

@joeparsons joeparsons moved this from Todo to In Progress in 2.14.0-alpha1 Mar 14, 2025
@joeparsons joeparsons moved this from Todo to In Progress in 3.0.0-alpha1 Jul 16, 2025
@joeparsons joeparsons moved this from Todo to In Progress in 4.0.0-alpha1 Aug 8, 2025
@joeparsons joeparsons removed this from 3.0.0-alpha1 Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration / automation dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Figure out how to manage patches with cweagans/composer-patches 2.x (or alternative)

2 participants