Closes #5300 Always show advanced display settings in Views UI.

[zsaenz]

Description

Closes Issue #5300
"Always show advanced display settings"
Appears closed in recent drupal update, see comment below. Suggest to close issue and PR without merging as already fixed in core.

Release notes

Related issues

How to test

-Install from scratch and make sure views shows advanced settings by default.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My change requires release notes.

[joshuasosa]

This PR adds views.settings.yml as a managed file. But as it is, when it comes in and drush config-distro-update is used, it will override any configuration that was previously there which is not ideal. It's possible that view settings were changed on a site, and those changes will be lost.

Example before update:

Example after update:

If possible, a database update or recipe that changes the one setting would be better.

[zsaenz]

In a recent update (most likely to Drupal 11.2.x), the Advanced Column feature was changed and removed. The view columns are no longer in an accordion, therefore can no longer be collapsed. The setting and its features are gone and no longer relevant. Test on any PR or updated installation of Quickstart.

https://github.com/drupal/drupal/blame/11.2.x/core/modules/views/views.install

drupal/drupal@88187a5#diff-4551dfbdf44dc54e10c06fee3faa9818d93a05732cf7d56b8ad1e8e401793df9

Suggest to close issue without merging this PR, already fixed in Core.

[joshuasosa]

In a recent update (most likely to Drupal 11.2.x), the Advanced Column feature was changed and removed. The view columns are no longer in an accordion, therefore can no longer be collapsed. The setting and its features are gone and no longer relevant. Test on any PR or updated installation of Quickstart.

https://github.com/drupal/drupal/blame/11.2.x/core/modules/views/views.install

drupal/drupal@88187a5#diff-4551dfbdf44dc54e10c06fee3faa9818d93a05732cf7d56b8ad1e8e401793df9

Suggest to close issue without merging this PR, already fixed in Core.

Does this mean this PR effectively no longer does anything? If so, you're welcome to close this PR and add a suggestion in the original issue to close it.

[danahertzberg]

Agreed with Josh. After testing on a sandbox site, it looks like this is no longer an issue.