Add ruff.toml configuration and fix pre-existing lint issues - #9
Merged
Merged
Conversation
Co-authored-by: azebro <1090464+azebro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on HACS compatibility and v1.0.0 release
Add ruff.toml configuration and fix pre-existing lint issues
Feb 23, 2026
azebro
marked this pull request as ready for review
February 23, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ruff checkCI step had no configuration file, leaving it running with opaque defaults that may not match the project's coding standards.Changes
ruff.toml— explicit lint configuration:line-length = 110(matches existing codebase max)E,W(pycodestyle),F(pyflakes),I(isort),UP(pyupgrade)force-sort-within-sections,known-first-party = ["custom_components.pytap"]Auto-fixed 35 pre-existing violations across 16 files via
ruff check --fix:I001) —config_flow.py,coordinator.py,sensor.py, and pytap internalsOptional[X]→X | None(UP045) —api.py,barcode.py,events.py,parser.py,source.py,state.pytyping.Iterator→collections.abc.Iterator(UP035) —types.pysocket.timeout→TimeoutError(UP041) —source.py💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.