fix(raf): update same-IP text based on endRAFOnSameIP setting#182
Merged
Nyeriah merged 1 commit intoazerothcore:masterfrom Mar 27, 2026
Merged
fix(raf): update same-IP text based on endRAFOnSameIP setting#182Nyeriah merged 1 commit intoazerothcore:masterfrom
Nyeriah merged 1 commit intoazerothcore:masterfrom
Conversation
…cefully When endRAFOnSameIP is disabled, show a more coherent message matching ChromieCraft's wording. Wrap Eluna DB queries in try/catch so the RAF page displays a clear error instead of a blank page when the database is not configured. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Nyeriah
force-pushed
the
fix/raf-same-ip-text
branch
from
0324430 to
eb9150a
Compare
Helias
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end_raf_on_same_ipsetting to the RAF config defaults and admin panel dropdownendRAFOnSameIPis enabled: keep the existing warning that RAF will be automatically removedendRAFOnSameIPis disabled: show a more coherent message matching ChromieCraft's wording — "Whilst you can recruit a friend who shares an IP address, you will only get the teleport & XP bonuses, no rewards will be given"Test plan
end_raf_on_same_ipto Enabled and confirm the original warning text appears on the RAF pageend_raf_on_same_ipto Disabled and confirm the updated ChromieCraft-style text appears🤖 Generated with Claude Code