Convert CRLF to LF on Windows Fix, enforce LF and updated README#183
Merged
Helias merged 6 commits intoazerothcore:masterfrom Apr 1, 2026
Merged
Conversation
Default: normalize all text files to LF in the repo Force shell scripts to always use LF (critical for Docker/Linux containers) Force Dockerfiles and docker-compose files to LF
Contributor
Author
|
CC @Helias |
TheSCREWEDSoftware
changed the title
Helias
approved these changes
Mar 31, 2026
Member
|
thank you, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the docker container couldn't startup on windows due to windows reading it as
CRLFwhen script excepted it to beLFWith this PR it progresses this: #162
As I haven't been possible to get the PHP / WP to work, with this PR you can run the container just the PHP / WP will fail (instead of failing the startup)
I no longer have my logs but i will share screenshots from Nyeriah having the same issue
This also creates
.gitattributesand enforcesLF, there was some an issue withUTF-8 BOMnot being read properly should be fixed.--renormalizewas ran to enforce the changes after convertion just to be safe.Readme was updated
I know acore-cms works out of the box in linux, it has never for me worked on windows (natively windows, not wsl or native linux)