feat: add transactions export command#74
Open
johann-taberlet wants to merge 2 commits intoazerpas:mainfrom
Open
feat: add transactions export command#74johann-taberlet wants to merge 2 commits intoazerpas:mainfrom
johann-taberlet wants to merge 2 commits intoazerpas:mainfrom
Conversation
Add a new `transactions` subcommand to export account transactions over a date range using BoursoBank's CSV export endpoint. - Add `Transaction` struct to `bourso_api::account` - Add `get_transactions()` method on `BoursoWebClient` - Handle redirect to `api.boursobank.com` for file download - Parse BoursoBank CSV (semicolon-separated, French number format) - Support CSV (default) and JSON output formats - Add unit tests for CSV parsing and amount conversion
Owner
|
Thank you very much for the contribution @johann-taberlet A few things top of my head:
|
- Move `transactions` under new `export` subcommand (`bourso export transactions`) - Rename `--from`/`--to` to `--start-date`/`--end-date` - Rename `--output` (format) to `--format`/`-f` - Add `--output`/`-o` for file output path (defaults to stdout)
Author
|
Thanks for the feedback @azerpas! All changes implemented in the latest commit:
Final usage: bourso export transactions -a <account_id> --start-date "01/01/2026" --end-date "31/01/2026" -f json -o /path/to/transactions.jsonAll 11 tests still passing, build OK. Tested manually with both CSV (stdout) and JSON (stdout) output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
transactionssubcommand to export account transactions over a date range, using BoursoBank's CSV export endpoint (/budget/exporter-mouvements).Changes
bourso_api::account: AddTransactionstruct with all fields from BoursoBank CSV exportbourso_api::client::transaction: Addget_transactions()method onBoursoWebClient/budget/exporter-mouvementsendpoint with date range and account filterapi.boursobank.comfor file download (since the client usesPolicy::none())Vecgracefully when an HTML error page is returnedtransactionssubcommand with--account,--from,--to,--outputargscsvcrate for robust CSV parsingTest plan
cargo build --releasecompiles without errorscargo test -p bourso_api— 11 tests pass (3 new:test_parse_amount,test_extract_transactions,test_extract_transactions_empty_html)-o json) works correctly