Repository navigation
store: Phase 3 follow-ups (bigint cursor, messaging cleanup, final $n sweep) - #401
Merged
Merged
Conversation
… sweep) ListCDRs and ListRecordings page with @before::bigint, as LookupCalls and LookupRecordings do, so a cursor above 2^31-1 no longer fails. ConversationCalls' visibility read binds @id with visibleTo and messaging_calls.go joins namedFiles. ErasePeer's redaction select binds @peer_key, so queueRedactions always binds @Batch. The $n helpers visible and poolMemberParam, and TestVisibleToMatchesVisible, are deleted. docs/database.md lists every internal/store domain as converted, with the deliberate raw exceptions (dbq.go, trylock.go, backup.go's goose read).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to the internal/store momo Phase 3 conversion.
Checks run locally: gofmt, go vet ./..., go build ./..., golangci-lint on internal/store, and the offline store tests plus the hermetic store, messaging and api unit tests. The DB tier runs in CI.