Repository navigation
test(perf): measure compiler memory of typed queries - #220
Merged
Merged
Conversation
Adds a deterministic fixture generator (N models through momo generate plus a caller package of Q typed queries), a compile-memory workflow that records the Go compiler's peak RSS for the default, -l and -c=1 builds, a symbolised compiler memory profile, an instantiated-generics report from go tool nm, and a budget guard on the default peak. Refs #217.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 1 of #217: measurement and a guard, no optimisation. A generator writes N models (run through the real momo generate) and a caller package of Q typed queries; a new compile-memory workflow compiles the caller package, records the Go compiler's peak RSS, profiles the compiler with a symbolised build, and fails above a budget.
Why
Packages that call momo's typed builders need 9-11 GB in the compiler (#217). There was no number in momo's CI and no symbolised profile.
How
Testing
Generator and nmreport unit tests run in CI. The measurement runs in the compile-memory check.
Notes for the reviewer
The first run uses a placeholder budget; it is set from the measured value plus headroom in a follow-up commit.
Checklist